Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vGPU number not correct #1253

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: vGPU number not correct #1253

merged 1 commit into from
Jan 3, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 2, 2025 •
edited
Loading

Summary

Consume domain?.devices?.gpus when VM is off, while consume harvesterhci.io/deviceAllocationDetails when VM is running

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#7003

Screenshot/Video

image

@a110605 a110605 requested review from Yu-Jack and torchiaf January 2, 2025 08:38
torchiaf
torchiaf approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 added Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4 labels Jan 2, 2025
@a110605 a110605 merged commit c4092c4 into harvester:master Jan 3, 2025
9 checks passed
This was referenced Jan 3, 2025
Merged
Merged
@a110605 a110605 mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

@Yu-Jack Yu-Jack Yu-Jack approved these changes

Assignees

@a110605 a110605

Labels
Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @Yu-Jack @torchiaf